Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Sidebar component #789

Closed
connor-baer opened this issue Jan 27, 2021 · 1 comment
Closed

Refresh Sidebar component #789

connor-baer opened this issue Jan 27, 2021 · 1 comment
Labels
⚛️ component Changes to a React component 🎨 design Requires input from designers
Milestone

Comments

@connor-baer
Copy link
Member

connor-baer commented Jan 27, 2021

Component to amend

👀 View Sidebar in Storybook

Design

In my opinion, the heavy use of a washed-out grey makes the sidebar look heavy, unappealing, and dated. I suggest changing it to a light color and using shadows, lines, or other ways of separating the navigation from the main content. This would also play better with dark mode 🌙 (#788).

Update: The design team seems to agree. This is a very early mockup of the redesigned sidenav (sorry for the bad quality):

ezgif com-gif-maker

The diversification of SumUp's product portfolio has led to the crowding of the sidebar. We've tried to counter this by grouping related items and hiding them behind an aggregator. This saves space but hurts discoverability. The purpose of the aggregator item itself is not clearly defined: when clicked, should it expand its sublinks or navigate to a route? Currently, it does both, but on mobile, it also closes the sidebar, so the user never sees the expanded sublinks.

API

The nav links are wrapped in Circuit UI's Link component which can be overridden using the ComponentContext. This is cumbersome and not well documented. I'd like to deprecate and remove the ComponentContext in an upcoming major release. This means it should be up to the developer to wrap the nav item in a Link component.

Circuit UI exposes a SidebarContextConsumer to access a function to toggle the sidebar. Instead, we should expose the SidebarContext, so it can be used with the useContext hook.

@connor-baer connor-baer added 🎨 design Requires input from designers ⚛️ component Changes to a React component labels Jan 27, 2021
@connor-baer connor-baer modified the milestones: v2.x, v3.0 Jan 29, 2021
@connor-baer connor-baer mentioned this issue Feb 27, 2021
49 tasks
@connor-baer connor-baer modified the milestones: v3.0, v3.x Jun 29, 2021
@connor-baer
Copy link
Member Author

Now available as the SideNavigation and TopNavigation components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚛️ component Changes to a React component 🎨 design Requires input from designers
Projects
None yet
Development

No branches or pull requests

1 participant