Fix Body's font weight #2765
Merged
Fix Body's font weight #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c37cdba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
==========================================
- Coverage 87.28% 87.28% -0.01%
==========================================
Files 214 214
Lines 12557 12563 +6
Branches 1684 1686 +2
==========================================
+ Hits 10961 10965 +4
- Misses 1543 1545 +2
Partials 53 53
|
|
Size Change: +23 B (0%) Total Size: 639 kB
ℹ️ View Unchanged
|
sirineJ
approved these changes
Nov 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When the Body component is rendered as a
strongelement, it should have a semibold font weight. It should be possible to override the font weight using theweightprop. In order to ensure the latter, we increased the specificity of the weight styles, thus breaking the former.Approach and changes
weightvalue tosemiboldwhen the component is rendered as astrongelementDefinition of done