Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement strverscmp #34

Closed
sunfishcode opened this issue Dec 12, 2023 · 2 comments
Closed

Implement strverscmp #34

sunfishcode opened this issue Dec 12, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@sunfishcode
Copy link
Owner

We should implement the strverscmp function, in c-scape/src/mem/ntbs.rs, and remove it from c-scape/src/todo.rs.

Here is the documentation for strverscmp.

I've labeled this a "good first issue", though that's admittedly relative. It requires familiarity with C strings and raw pointers. For some examples, see the other functions in ntbs.rs.
@sunfishcode sunfishcode added the good first issue Good for newcomers label Dec 12, 2023
@KGrewal1 KGrewal1 mentioned this issue Dec 18, 2023
Merged
@KGrewal1
Copy link

I've opened a PR in the c-scape repo sunfishcode/c-ward#99

@sunfishcode
Copy link
Owner Author

sunfishcode/c-ward#99 is now merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunfishcode @KGrewal1