Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only instrument loading classes should be passed to the fitter, nothing else #119

Open
KriSun95 opened this issue Oct 2, 2023 · 0 comments

Comments

@KriSun95
Copy link
Collaborator

KriSun95 commented Oct 2, 2023

Describe the feature

Previously, only files and dictionaries containing data to be fitted could be passed to the fitting code. This was improved in #107 where a bug was fixed and the instrument loader classes were allowed to be passed.

The proposed feature in this Issue is to only allow the instrument loaders to be passed. This will detangle a lot of code while making it simpler to separate and maintain code relating to different instruments right now and in the future.

Proposed solution

Remove the ability to pass files and dictionaries to the fitting code. Instead, the files will be given to the relevant instrument loader which can then be passed to the fitting code. Likewise, custom dictionaries from a user's unsupported instrument or source can be given to the CustomLoader() and then passed.

This change should be consistent with and support any future re-factor to the code, especially when making it more modular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant