-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add albedo correction #128
Comments
I think that would be an excellent addition. I believe OSPEX implements it as a “pseudo-model” but it shouldn’t be too hard to add if we look up the proper equations. |
This has been on my to-do list for a while, I've just never been able to get around to it properly. I think OSPEX does it via altering the response matrix before the fit and I think the main files to look at are drm_albedo.pro and drm_correct_albedo.pro (found here with some description). Instructions on how the user interacts with this in OSPEX and some history is here. |
@samaloney, I think your idea of |
For RHESSI the albedo correction is included as part of the DRM, the logic being that it's not the observed spectrum |
Green function matrices are now available in JSON format (also as IDL SAVE files) https://github.com/edkontar/albedo |
@edkontar thanks, Eduard! this will be very useful for albedo corrections going forward. would you like to help implement the corrections in Python? |
Yes, I would be happy to help |
I have a draft PR open which uses the sav files from SSW in #161 What we eventually need is the ability to generate the "green's matrices" |
Describe the feature
A few people have been asking if we have implemented the albedo correction similar to OSPEX
Proposed solution
No response
The text was updated successfully, but these errors were encountered: