fix: don't call removeSession prematurely #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
I think generally fine, though I think we need to emit the SIGNED_OUT event in this case (if there was a session previously) and right after SIGNED_IN.
But for now, let's just document this here: https://supabase.com/docs/reference/javascript/auth-onauthstatechange
J0
approved these changes
Jun 7, 2024
hf
pushed a commit
that referenced
this pull request
Jun 17, 2024
🤖 I have created a release *beep* *boop* --- ## [2.64.3](v2.64.2...v2.64.3) (2024-06-17) ### Bug Fixes * don't call removeSession prematurely ([#915](#915)) ([e0dc518](e0dc518)) * limit proxy session warning to once per client instance ([#900](#900)) ([4ecfdda](4ecfdda)) * patch release workflow ([#922](#922)) ([f84fb50](f84fb50)) * type errors in verifyOtp ([#918](#918)) ([dcd0b9b](dcd0b9b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
SIGNED_OUTevent where session is removed #854_removeSessioninternally do not triggerSIGNED_OUTevent when the function fails #853, Current session lost when auth function call fails #904_removeSessionsince calling_saveSessionmultiple times will just replace the existing session