feat: add test OTP support for mobile app reviews

supabase · Jul 4, 2023 · e772a40 · e772a40
1 parent 154dd91
commit e772a40
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 15 deletions.
diff --git a/internal/api/phone.go b/internal/api/phone.go
@@ -68,29 +68,42 @@ func (a *API) sendPhoneConfirmation(ctx context.Context, tx *storage.Connection,
 		return "", internalServerError("invalid otp type")
 	}
 
+	// intentionally keeping this before the test OTP, so that the behavior
+	// of regular and test OTPs is similar
 	if sentAt != nil && !sentAt.Add(config.Sms.MaxFrequency).Before(time.Now()) {
 		return "", MaxFrequencyLimitError
 	}
-	oldToken := *token
-	otp, err := crypto.GenerateOtp(config.Sms.OtpLength)
-	if err != nil {
-		return "", internalServerError("error generating otp").WithInternalError(err)
-	}
-	*token = fmt.Sprintf("%x", sha256.Sum224([]byte(phone+otp)))
 
-	var message string
-	if config.Sms.Template == "" {
-		message = fmt.Sprintf(defaultSmsMessage, otp)
-	} else {
-		message = strings.Replace(config.Sms.Template, "{{ .Code }}", otp, -1)
+	var otp, messageID string
+
+	if config.External.Phone.Enabled && config.External.Phone.TestOTP != nil {
+		if testOTP, ok := config.External.Phone.TestOTP[phone]; ok && testOTP != "" {
+			otp = testOTP
+			messageID = "test-otp"
+		}
 	}
 
-	messageID, serr := smsProvider.SendMessage(phone, message, channel)
-	if serr != nil {
-		*token = oldToken
-		return messageID, serr
+	if otp == "" { // not using test OTPs
+		otp, err := crypto.GenerateOtp(config.Sms.OtpLength)
+		if err != nil {
+			return "", internalServerError("error generating otp").WithInternalError(err)
+		}
+
+		var message string
+		if config.Sms.Template == "" {
+			message = fmt.Sprintf(defaultSmsMessage, otp)
+		} else {
+			message = strings.Replace(config.Sms.Template, "{{ .Code }}", otp, -1)
+		}
+
+		messageID, err = smsProvider.SendMessage(phone, message, channel)
+		if err != nil {
+			return messageID, err
+		}
 	}
 
+	*token = fmt.Sprintf("%x", sha256.Sum224([]byte(phone+otp)))
+
 	now := time.Now()
 
 	switch otpType {

diff --git a/internal/conf/configuration.go b/internal/conf/configuration.go
@@ -193,6 +193,8 @@ type MailerConfiguration struct {
 
 type PhoneProviderConfiguration struct {
 	Enabled bool `json:"enabled" default:"false"`
+
+	TestOTP map[string]string `json:"test_otp" split_words:"true"`
 }
 
 type SmsProviderConfiguration struct {