Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maintain query params order #1161

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Maintains the order of the query params passed into the email link

@kangmingtay kangmingtay requested a review from a team as a code owner June 30, 2023 16:01
internal/mailer/mailer.go Outdated Show resolved Hide resolved
Copy link

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kangmingtay kangmingtay merged commit c925065 into master Jul 3, 2023
@kangmingtay kangmingtay deleted the km/maintain-query-params-order branch July 3, 2023 16:11
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

🎉 This PR is included in version 2.79.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?
* Maintains the order of the query params passed into the email link
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?
* Maintains the order of the query params passed into the email link
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
## What kind of change does this PR introduce?
* Maintains the order of the query params passed into the email link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants