-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SSO PKCE #707
feat: add SSO PKCE #707
Conversation
Thank you for this PR, currently |
What's the status on this PR? I could really do with it being merged in! Anything I can help with? 😄 |
## What kind of change does this PR introduce? Adds support for PKCE to the SSO flow - We don't introduce a foreign key since we can have relay states which use the implicit flow and won't have an associated flow state. How this was tested: - On staging with Okta as IDP, on an instance with the branch version of GoTrue uploaded GoTrue-js PR: - supabase/auth-js#707 --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
Hey @tedsmitt, Thanks for the offer of help but I don't think there's anything that can be done at the moment which would move the needle forward. We'll get this reviewed once our next Auth deploy goes out which should be in a week or two. Thanks for your patience! |
Did the new gotrue version get deloyed? How can we keep track of deployments? |
Hey @remorses Unfortunately, it hasn't gone out yet. It's slated to go soon though. We'll keep you posted. Thanks for your patience! |
Any update? I would love to start using SSO with Next.js |
🎉 This PR is included in version 2.57.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
Companion PR to: supabase/auth#1137
Server-Side PR: PKCE supabase/auth#1137