Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SSO PKCE #707

Merged
merged 1 commit into from
Oct 20, 2023
Merged

feat: add SSO PKCE #707

merged 1 commit into from
Oct 20, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Jun 21, 2023 •
edited
Loading

What kind of change does this PR introduce?

Companion PR to: supabase/auth#1137

Server-Side PR: PKCE supabase/auth#1137

@J0 J0 marked this pull request as ready for review June 28, 2023 13:17
@J0 J0 mentioned this pull request Jul 3, 2023
Merged
@remorses
Copy link

remorses commented Aug 9, 2023

Thank you for this PR, currently signInWithSSO is broken when using PKCE, it seems detectSessionInUrl does not detect access_token when using the auth helpers in next.js

@tedsmitt
Copy link

What's the status on this PR? I could really do with it being merged in! Anything I can help with? 😄

J0 added a commit to supabase/auth that referenced this pull request Aug 23, 2023
@J0
feat: add sso pkce (#1137)
2c0e0a1 
## What kind of change does this PR introduce?

Adds support for PKCE to the SSO flow

- We don't introduce a foreign key since we can have relay states which
use the implicit flow and won't have an associated flow state.

How this was tested:
- On staging with Okta as IDP, on an instance with the branch version of
GoTrue uploaded

GoTrue-js PR:
- supabase/auth-js#707

---------

Co-authored-by: joel@joellee.org <joel@joellee.org>
@J0
Copy link
Contributor Author

J0 commented Aug 23, 2023

Hey @tedsmitt,

Thanks for the offer of help but I don't think there's anything that can be done at the moment which would move the needle forward. We'll get this reviewed once our next Auth deploy goes out which should be in a week or two.

Thanks for your patience!

@remorses
Copy link

remorses commented Sep 6, 2023

Did the new gotrue version get deloyed? How can we keep track of deployments?

@J0
Copy link
Contributor Author

J0 commented Sep 7, 2023

Hey @remorses

Unfortunately, it hasn't gone out yet. It's slated to go soon though. We'll keep you posted.

Thanks for your patience!
Joel

@remorses
Copy link

Any update? I would love to start using SSO with Next.js

@J0 J0 requested review from thorwebdev, hf, silentworks and kangmingtay and removed request for thorwebdev October 20, 2023 03:42
@J0 J0 merged commit ba66b4d into master Oct 20, 2023
@J0 J0 deleted the j0/add_sso_pkce branch October 20, 2023 04:02
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangmingtay kangmingtay kangmingtay approved these changes

@hf hf Awaiting requested review from hf

@thorwebdev thorwebdev Awaiting requested review from thorwebdev

@silentworks silentworks Awaiting requested review from silentworks

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@J0 @remorses @tedsmitt @kangmingtay