feat: pkce challenge support in React Native with Segment #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR fixes an issue where gotrue would throw in React Native due to the lack of the crypto and TextEncoder module.
When integrating Segment with React Native, they ask you to install react-native-get-random-values as a polyfill to crypto's
getRandomValue
method. This causes issues in gotrue, as the code does a simplecrypto !== undefined
check.Since a lot of RN libraries polyfill only a subset of crypto's method,
crypto !== undefined
is not a bullet-proof way to check for support.What is the current behavior?
If you have Segment installed, and try to login with
supabase.auth.signInWithOtp
(email), the app throws an error.What is the new behavior?
If the required crypto modules are not available, it just fallbacks to plain text as the existing behavior instead of throwing an error.