feat: provide default storage when persistSession is false or localStorage is not supported
#774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/default-memory-storage
branch
2 times, most recently
from
d0d2ff1
to
94ba7b6
Compare
J0
reviewed
Sep 1, 2023
| @@ -1756,11 +1748,7 @@ export default class GoTrueClient { | |||
| private async _removeSession() { | |||
| this._debug('#_removeSession()') | |||
|
|
|||
| if (this.persistSession) { | |||
| await removeItemAsync(this.storage, this.storageKey) | |||
| } else { | |||
There was a problem hiding this comment.
Ah okay was slow to figure it out so calling it out explicitly for future ref feel free to correct me if my understanding is off.
Looks like we no longer need to check persistSession since there's a default inMemorySession when persistSession is set to false. Consequently there's no need to check for the persistSession before calling removeItemAsync since it will now default to the in memory session
J0
approved these changes
Sep 1, 2023
This comment was marked as outdated.
This comment was marked as outdated.
…lStorage` is not supported
hf
force-pushed
the
hf/default-memory-storage
branch
from
94ba7b6
to
b62d8b4
Compare
|
Tested this with Supabase Dashboard. Seems to be working! |
|
🎉 This PR is included in version 2.53.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a default memory-based, per client, storage interface when the
persistSessionis set to false (which previously used a similar approach) or when thestorageoption is not set and the current environment is not a browser or has nolocalStorageregistered onglobalThis.With this PR, the warning that was often emitted in server-side environments is gone, as those environments now gracefully and safely fall back to using per-client memory storage.