feat: acquire locks around mfa methods #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
approved these changes
Sep 18, 2023
kangmingtay
previously requested changes
Sep 18, 2023
hf
force-pushed
the
hf/acquire-locks-mfa
branch
from
bc07b33
to
38e7bc3
Compare
hf
force-pushed
the
hf/acquire-locks-mfa
branch
from
38e7bc3
to
eb70c44
Compare
|
Tested on supabase.com. |
|
🎉 This PR is included in version 2.54.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the changes introduced in #736, some of the MFA methods were exempt from acquiring the lock. However, this appears to have been a bad idea, especially around
_getAuthenticatedAssuranceLevelwhich is used while the user is authenticated.This PR adds the locks in the correct places.