Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default to navigatorLock on browsers #807

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

hf
Copy link
Contributor

@hf hf commented Oct 25, 2023

After having spent months of real-world testing on supabase.com, the navigatorLock is enabled on browsers that support the Navigator LocksManager API.

This makes sure that concurrent access to the storage in multiple tabs, windows or promises is no longer possible, thus removing issues such as:

  • Refreshing the session in parallel
  • Saving inconsistent state to storage

@BenIsenstein
Copy link

Wondering when can we expect to have this merged?

@hf
Copy link
Contributor Author

hf commented Dec 20, 2023

Right now.

@hf hf merged commit b717b1c into master Dec 20, 2023
2 checks passed
@hf hf deleted the hf/default-to-navigator-lock branch December 20, 2023 13:52
Copy link
Contributor

🎉 This PR is included in version 2.62.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Klunk75
Copy link

Klunk75 commented Jan 6, 2024

Hi there,
this merge seems to be causing this issue now: supabase/supabase-js#936
Can you please double check?
Thank you!

Paolo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants