Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Type error on code exchange when no item in storage #825

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

dshukertjr
Copy link
Member

What kind of change does this PR introduce?

Currently when code exchange for pkce flow is triggered on device that didn't start the auth flow (e.g. signed up via magic link on laptop and clicked on the link on phone), TypeError: Cannot read properties of null (reading 'split') error is thrown. This PR fixes that.

Fixes the error pointed out here
#813 (comment)

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tyler!

@dshukertjr dshukertjr merged commit 6d6ec13 into master Dec 17, 2023
2 checks passed
@dshukertjr dshukertjr deleted the fix/typeError branch December 17, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants