feat: warn use of getSession() when isServer on storage
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/storage-is-server
branch
from
a07d81d
to
d4b8a4d
Compare
kangmingtay
pushed a commit
that referenced
this pull request
Mar 28, 2024
🤖 I have created a release *beep* *boop* --- ## [2.63.0](v2.62.2...v2.63.0) (2024-03-26) ### Features * add method for anonymous sign-in ([#858](#858)) ([e8a1fc9](e8a1fc9)) * add support for error codes ([#855](#855)) ([99821f4](99821f4)) * explicit `cache: no-store` in fetch ([#847](#847)) ([034bee0](034bee0)) * warn use of `getSession()` when `isServer` on storage ([#846](#846)) ([9ea94fe](9ea94fe)) ### Bug Fixes * refactor all pkce code into a single method ([#860](#860)) ([860bffc](860bffc)) * remove data type ([#848](#848)) ([15c7c82](15c7c82)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn about using
getSession()when the storage hasisSeverto true without previously having calledgetUser().Warn each time the
useris accessed as returned bygetSession().Relates to:
isServerproperty to server-side storage adapters auth-helpers#722