-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return SMS ID when possible #1145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/add-sms-id
branch
4 times, most recently
from
June 19, 2023 02:49
4d80bd3
to
0550c48
Compare
kangmingtay
reviewed
Jun 19, 2023
J0
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm if it’s been tested
🎉 This PR is included in version 2.73.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hf
added a commit
to supabase/auth-js
that referenced
this pull request
Jun 19, 2023
When GoTrue returns a `message_id` it should be made available to OTP APIs. See: - supabase/auth#1145
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Returns the SMS message ID as received from the SMS sending provider in `/otp` and `/resend` to aid in debugging deliverability issues. Logs also include the message ID when available.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
Returns the SMS message ID as received from the SMS sending provider in `/otp` and `/resend` to aid in debugging deliverability issues. Logs also include the message ID when available.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
Returns the SMS message ID as received from the SMS sending provider in `/otp` and `/resend` to aid in debugging deliverability issues. Logs also include the message ID when available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns the SMS message ID as received from the SMS sending provider in
/otp
and/resend
to aid in debugging deliverability issues. Logs also include the message ID when available.