Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return SMS ID when possible #1145

Merged
merged 1 commit into from
Jun 19, 2023
Merged

feat: return SMS ID when possible #1145

merged 1 commit into from
Jun 19, 2023

Conversation

hf
Copy link
Contributor

@hf hf commented Jun 16, 2023

Returns the SMS message ID as received from the SMS sending provider in /otp and /resend to aid in debugging deliverability issues. Logs also include the message ID when available.

@hf hf requested a review from a team as a code owner June 16, 2023 17:43
@hf hf force-pushed the hf/add-sms-id branch 4 times, most recently from 4d80bd3 to 0550c48 Compare June 19, 2023 02:49
internal/api/otp.go Outdated Show resolved Hide resolved
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm if it’s been tested

@hf hf merged commit 02cb927 into master Jun 19, 2023
@hf hf deleted the hf/add-sms-id branch June 19, 2023 05:21
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.73.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

hf added a commit to supabase/auth-js that referenced this pull request Jun 19, 2023
When GoTrue returns a `message_id` it should be made available to OTP
APIs.

See:
- supabase/auth#1145
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
Returns the SMS message ID as received from the SMS sending provider in
`/otp` and `/resend` to aid in debugging deliverability issues. Logs
also include the message ID when available.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
Returns the SMS message ID as received from the SMS sending provider in
`/otp` and `/resend` to aid in debugging deliverability issues. Logs
also include the message ID when available.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
Returns the SMS message ID as received from the SMS sending provider in
`/otp` and `/resend` to aid in debugging deliverability issues. Logs
also include the message ID when available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants