fix: remove optional dependencies #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silentworks
changed the title
|
would appreciate this being added asap : ) |
sansjack
approved these changes
Jul 20, 2024
J0
approved these changes
Jul 30, 2024
J0
force-pushed
the
silentworks/remove-optional-deps
branch
from
6056fdb
to
eeac106
Compare
hf
pushed a commit
that referenced
this pull request
Aug 28, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.1](v0.5.0...v0.5.1) (2024-08-28) ### Bug Fixes * remove optional dependencies ([#41](#41)) ([a48fe6f](a48fe6f)) * set `max-age` default cookie option to 400 days ([#54](#54)) ([f4ed2e0](f4ed2e0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is causing an issue for a user when deploying to vercel as it's trying to install this optional dependency. However it doesn't look like this optional dependency is being used anywhere in this project.
What is the current behavior?
Optional dependency is not being used.
What is the new behavior?
Remove optional dependency.
Additional context
Add any other context or screenshots.