[Fix #47] Refactor git checking #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure directory can be cd'd into - cd into folders to check for repo - run git commands from correct directory - check for repo in each base_dir, using $GIT_TOPLEVEL for entire base_dir - consolidate git-related (repomarker) code - removed use of $IS_GIT_REPO
|
Nice! thanks, will have to find some time to give a proper review, will get on it as soon as possible. |
|
No problem, please let me know if anything's against your preferred style! |
|
Hey there, just wanted to let you know I hadn't forgotten about this, just been very busy recently. I have just cracked how to do unit tests for |
|
No worries, testing looks really neat! By the way, I just figured out how to preserve |
…ctor # Conflicts: # k.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up runtime by 20-25%. Addresses issues with supplied git directories (#47)
pushdinto folders to check for repo$GIT_TOPLEVELfor entirebase_dir$IS_GIT_REPO