Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Etherscan code verification #169

Closed
2 of 3 tasks
hellwolf opened this issue Jan 1, 2021 · 1 comment · Fixed by #223
Closed
2 of 3 tasks

Etherscan code verification #169

hellwolf opened this issue Jan 1, 2021 · 1 comment · Fixed by #223
Assignees
@hellwolf
Milestone
ethereum-contract...

Comments

@hellwolf
Copy link
Contributor

hellwolf commented Jan 1, 2021 •
edited
Loading

Checklist

  • Verify all the proxy contracts.
  • For all new logic contracts update, do etherscan.
  • (If possible) add extra deployment information when doing etherscan.

Notes:

  • Since adding comments wouldn't change compilation bytecode output, it would be convenient to have those deployment information as code comments on etherscan.
@hellwolf hellwolf added the devX label Jan 1, 2021
@hellwolf hellwolf added this to the v1.0 milestone Jan 1, 2021
@hellwolf hellwolf added process and removed devX labels Jan 16, 2021
@hellwolf hellwolf changed the title Add deployment information during etherscan code verification Etherscan code verification Jan 27, 2021
@hellwolf hellwolf self-assigned this Jan 27, 2021
@hellwolf
Copy link
Contributor Author

hellwolf commented Jan 28, 2021 •
edited
Loading

Pull requested for the truffle-plugin-verify project for forced constructor args support: rkalis/truffle-plugin-verify#61

@hellwolf hellwolf linked a pull request Jan 28, 2021 that will close this issue
Build process: etherscan support #223
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hellwolf hellwolf

Labels
None yet
Projects
None yet
Milestone
ethereum-contracts@v1.0 - Out of RCs
Development

Successfully merging a pull request may close this issue.

Build process: etherscan support superfluid-finance/protocol-monorepo
1 participant
@hellwolf