Using fly launch vs fly apps create?

[jamaljsr]

This is part question and maybe a suggestion. Why does this action use fly launch instead of fly apps create?

I recently ran into an issue where the initial PR deployment of my app would not succeed due to healthchecks not being triggered. After getting some help in the community forums, it turn out that fly launch was modifying my fly.toml file to include the [http_service] section. This is what was breaking my deployments.

It may be a good idea for this action to check for the existence of a fly.toml file in the repo. If it does not exist, then run fly launch to deploy the app, otherwise run fly apps create so that these unexpected modifications do not occur.

[fredericrous]

there is a protection to keep fly.toml unchanged on this github action tho

fly-pr-review-apps/entrypoint.sh

Line 42 in 280ea61

cp "$config" "$config.bak"