From 3754acb641746d2c6e3eada9d925101232f56da0 Mon Sep 17 00:00:00 2001
From: Deepjyoti Barman <deepjyoti@supertokens.com>
Date: Wed, 25 Sep 2024 12:04:10 +0530
Subject: [PATCH] Update some errors to indicate unreachable errors

---
 .../emailpassword/api/implementation.ts       | 30 ++++---------------
 1 file changed, 6 insertions(+), 24 deletions(-)

diff --git a/lib/ts/recipe/emailpassword/api/implementation.ts b/lib/ts/recipe/emailpassword/api/implementation.ts
index d05a05bf8..531f7cd9e 100644
--- a/lib/ts/recipe/emailpassword/api/implementation.ts
+++ b/lib/ts/recipe/emailpassword/api/implementation.ts
@@ -70,10 +70,7 @@ export default function getAPIImplementation(): APIInterface {
             // in validation but kept here to be safe.
             const emailAsUnknown = formFields.filter((f) => f.id === "email")[0].value;
             if (typeof emailAsUnknown !== "string")
-                return {
-                    status: "GENERAL_ERROR",
-                    message: "email value needs to be a string",
-                };
+                throw new Error("Should never come here since we already check that the email value is a string in validateFormFieldsOrThrowError");
             const email: string = emailAsUnknown;
 
             // this function will be reused in different parts of the flow below..
@@ -464,10 +461,7 @@ export default function getAPIImplementation(): APIInterface {
             // in validation but kept here to be safe.
             const newPasswordAsUnknown = formFields.filter((f) => f.id === "password")[0].value;
             if (typeof newPasswordAsUnknown !== "string")
-                return {
-                    status: "GENERAL_ERROR",
-                    message: "password value needs to be a string",
-                };
+                throw new Error("Should never come here since we already check that the password value is a string in validateFormFieldsOrThrowError");
             let newPassword: string = newPasswordAsUnknown;
 
             let tokenConsumptionResponse = await options.recipeImplementation.consumePasswordResetToken({
@@ -657,16 +651,10 @@ export default function getAPIImplementation(): APIInterface {
             // check for type is done in a parent function but they are kept
             // here to be on the safe side.
             if (typeof emailAsUnknown !== "string")
-                return {
-                    status: "GENERAL_ERROR",
-                    message: "email value needs to be a string",
-                };
+                throw new Error("Should never come here since we already check that the email value is a string in validateFormFieldsOrThrowError");
 
             if (typeof passwordAsUnknown !== "string")
-                return {
-                    status: "GENERAL_ERROR",
-                    message: "password value needs to be a string",
-                };
+                throw new Error("Should never come here since we already check that the password value is a string in validateFormFieldsOrThrowError");
 
             let email: string = emailAsUnknown;
             let password: string = passwordAsUnknown;
@@ -828,16 +816,10 @@ export default function getAPIImplementation(): APIInterface {
             // check for type is done in a parent function but they are kept
             // here to be on the safe side.
             if (typeof emailAsUnknown !== "string")
-                return {
-                    status: "GENERAL_ERROR",
-                    message: "email value needs to be a string",
-                };
+                throw new Error("Should never come here since we already check that the email value is a string in validateFormFieldsOrThrowError");
 
             if (typeof passwordAsUnknown !== "string")
-                return {
-                    status: "GENERAL_ERROR",
-                    message: "password value needs to be a string",
-                };
+                throw new Error("Should never come here since we already check that the password value is a string in validateFormFieldsOrThrowError");
 
             let email: string = emailAsUnknown;
             let password: string = passwordAsUnknown;