From d80ca836757e6c8495c0b3eeb1fa1ffcaf374426 Mon Sep 17 00:00:00 2001
From: rishabhpoddar <rishabh.poddar@gmail.com>
Date: Wed, 7 Aug 2024 17:41:29 +0530
Subject: [PATCH] refactors an exception case

---
 lib/build/recipe/accountlinking/index.js    | 3 +++
 lib/build/recipe/accountlinking/recipe.d.ts | 2 +-
 lib/build/recipe/accountlinking/recipe.js   | 3 ---
 lib/ts/recipe/accountlinking/index.ts       | 4 ++++
 lib/ts/recipe/accountlinking/recipe.ts      | 6 +-----
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/lib/build/recipe/accountlinking/index.js b/lib/build/recipe/accountlinking/index.js
index 68e7fbbb5..f65eeeaee 100644
--- a/lib/build/recipe/accountlinking/index.js
+++ b/lib/build/recipe/accountlinking/index.js
@@ -129,6 +129,9 @@ class Wrapper {
     }
     static async isEmailChangeAllowed(recipeUserId, newEmail, isVerified, session, userContext) {
         const user = await __1.getUser(recipeUserId.getAsString(), userContext);
+        if (user === undefined) {
+            throw new Error("Passed in recipe user id does not exist");
+        }
         const res = await recipe_1.default.getInstance().isEmailChangeAllowed({
             user,
             newEmail,
diff --git a/lib/build/recipe/accountlinking/recipe.d.ts b/lib/build/recipe/accountlinking/recipe.d.ts
index 0bf9c36d0..5a850c2a0 100644
--- a/lib/build/recipe/accountlinking/recipe.d.ts
+++ b/lib/build/recipe/accountlinking/recipe.d.ts
@@ -99,7 +99,7 @@ export default class Recipe extends RecipeModule {
         userContext: UserContext;
     }) => Promise<boolean>;
     isEmailChangeAllowed: (input: {
-        user?: User;
+        user: User;
         newEmail: string;
         isVerified: boolean;
         session: SessionContainerInterface | undefined;
diff --git a/lib/build/recipe/accountlinking/recipe.js b/lib/build/recipe/accountlinking/recipe.js
index 0e29dd06f..47f375b1d 100644
--- a/lib/build/recipe/accountlinking/recipe.js
+++ b/lib/build/recipe/accountlinking/recipe.js
@@ -385,9 +385,6 @@ class Recipe extends recipeModule_1.default {
              * in account take over if this recipe user is malicious.
              */
             let inputUser = input.user;
-            if (inputUser === undefined) {
-                throw new Error("Passed in recipe user id does not exist");
-            }
             for (const tenantId of inputUser.tenantIds) {
                 let existingUsersWithNewEmail = await this.recipeInterfaceImpl.listUsersByAccountInfo({
                     tenantId,
diff --git a/lib/ts/recipe/accountlinking/index.ts b/lib/ts/recipe/accountlinking/index.ts
index 995a341e0..e878130e2 100644
--- a/lib/ts/recipe/accountlinking/index.ts
+++ b/lib/ts/recipe/accountlinking/index.ts
@@ -165,6 +165,10 @@ export default class Wrapper {
     ) {
         const user = await getUser(recipeUserId.getAsString(), userContext);
 
+        if (user === undefined) {
+            throw new Error("Passed in recipe user id does not exist");
+        }
+
         const res = await Recipe.getInstance().isEmailChangeAllowed({
             user,
             newEmail,
diff --git a/lib/ts/recipe/accountlinking/recipe.ts b/lib/ts/recipe/accountlinking/recipe.ts
index d7f5a33ce..8bfe1a8b1 100644
--- a/lib/ts/recipe/accountlinking/recipe.ts
+++ b/lib/ts/recipe/accountlinking/recipe.ts
@@ -523,7 +523,7 @@ export default class Recipe extends RecipeModule {
     };
 
     isEmailChangeAllowed = async (input: {
-        user?: User;
+        user: User;
         newEmail: string;
         isVerified: boolean;
         session: SessionContainerInterface | undefined;
@@ -546,10 +546,6 @@ export default class Recipe extends RecipeModule {
 
         let inputUser = input.user;
 
-        if (inputUser === undefined) {
-            throw new Error("Passed in recipe user id does not exist");
-        }
-
         for (const tenantId of inputUser.tenantIds) {
             let existingUsersWithNewEmail = await this.recipeInterfaceImpl.listUsersByAccountInfo({
                 tenantId,