Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_MSC_VER macro is specific to IDE #15

Open
utdrmac opened this issue Jun 21, 2023 · 0 comments
Open

_MSC_VER macro is specific to IDE #15

utdrmac opened this issue Jun 21, 2023 · 0 comments

Comments

@utdrmac
Copy link

utdrmac commented Jun 21, 2023

Using this library in a linux application, compiled with g++:

/home/xxxx/percona-server-8.0.32-24/plugin/ulid/ulid/src/ulid_uint128.hh:11:5: warning: "_MSC_VER" is not defined, evaluates to 0 [-Wundef]
 #if _MSC_VER > 0
     ^~~~~~~~

A quick google says _MSC_VER is something specific to Visual Studio Code. Please add an #ifdef before checking the value so that other IDEs/compilers don't complain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant