Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_triangles_per_surface for new design #92

Closed
yqin43 opened this issue Jan 27, 2022 · 3 comments · Fixed by #95
Closed

Update get_triangles_per_surface for new design #92

yqin43 opened this issue Jan 27, 2022 · 3 comments · Fixed by #95

Comments

@yqin43
Copy link
Contributor

yqin43 commented Jan 27, 2022

No description provided.

@gonuke
Copy link
Member

gonuke commented Feb 6, 2022

How does this method fit into the new design? The current design already get all the triangles for all the surfaces in the meshset that is used to setup the DagmcQuery object. What's the use case that we are missing and how would it work?

@gonuke
Copy link
Member

gonuke commented Feb 6, 2022

Maybe a related question... is this a method of DagmcFile or DagmcQuery in our current design?

@yqin43
Copy link
Contributor Author

yqin43 commented Feb 6, 2022

How does this method fit into the new design? The current design already get all the triangles for all the surfaces in the meshset that is used to setup the DagmcQuery object. What's the use case that we are missing and how would it work?
This function was in the original dagmc_stats.py file when I took over this work. It calculates the number of triangles of each surface instead of getting the triangles.
I think it should be put into the DagmcQuery function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants