Generalized no-goto-without-base into no-navigation-without-base
#900
+792
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: daa9785 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marekdedic
force-pushed
the
no-navigation-without-base
branch
6 times, most recently
from
3484782
to
1850e76
Compare
marekdedic
force-pushed
the
no-navigation-without-base
branch
from
1850e76
to
4054b8c
Compare
marekdedic
force-pushed
the
no-navigation-without-base
branch
2 times, most recently
from
dc92c50
to
daa932b
Compare
marekdedic
force-pushed
the
no-navigation-without-base
branch
from
daa932b
to
8a9a43d
Compare
ota-meshi
requested changes
Nov 27, 2024
| } | ||
| } | ||
| })) { | ||
| const variable = findVariable(context, (node as TSESTree.ImportSpecifier).local); |
There was a problem hiding this comment.
Could you please add a test case to see if the following import works?
import * as paths from '$app/paths';
paths.base;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #891