From 1f83839480908e72c0c7ca7cf987310f57d58433 Mon Sep 17 00:00:00 2001
From: Ben McCann <322311+benmccann@users.noreply.github.com>
Date: Tue, 14 Nov 2023 12:56:59 -0800
Subject: [PATCH] fix: only resolve images if optimizable

---
 .changeset/sour-worms-buy.md              |  5 ++++
 packages/enhanced-img/src/preprocessor.js | 28 +++++++++++------------
 2 files changed, 19 insertions(+), 14 deletions(-)
 create mode 100644 .changeset/sour-worms-buy.md

diff --git a/.changeset/sour-worms-buy.md b/.changeset/sour-worms-buy.md
new file mode 100644
index 000000000000..99deafa6fa23
--- /dev/null
+++ b/.changeset/sour-worms-buy.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/enhanced-img': patch
+---
+
+fix: only resolve images if optimizable
diff --git a/packages/enhanced-img/src/preprocessor.js b/packages/enhanced-img/src/preprocessor.js
index 1957d1259be5..694cf7a8ff96 100644
--- a/packages/enhanced-img/src/preprocessor.js
+++ b/packages/enhanced-img/src/preprocessor.js
@@ -65,19 +65,19 @@ export function image(opts) {
 				}
 				url += 'enhanced';
 
-				let details = images.get(url);
-				if (!details) {
-					// resolves the import so that we can build the entire picture template string and don't
-					// need any logic blocks
-					const image = await resolve(opts, url, filename);
-					if (!image) {
-						return;
-					}
-					details = images.get(url) || { name: ASSET_PREFIX + images.size, image };
-					images.set(url, details);
-				}
-
+				const name = ASSET_PREFIX + images.size;
 				if (OPTIMIZABLE.test(url)) {
+					let details = images.get(url);
+					if (!details) {
+						// resolves the import so that we can build the entire picture template string and don't
+						// need any logic blocks
+						const image = await resolve(opts, url, filename);
+						if (!image) {
+							return;
+						}
+						details = images.get(url) || { name, image };
+						images.set(url, details);
+					}
 					s.update(node.start, node.end, img_to_picture(content, node, details));
 				} else {
 					// e.g. <img src="./foo.svg" /> => <img src={___ASSET___0} />
@@ -86,11 +86,11 @@ export function image(opts) {
 					s.update(
 						is_quote(content, start - 1) ? start - 1 : start,
 						is_quote(content, end) ? end + 1 : end,
-						`{${details.name}}`
+						`{${name}}`
 					);
 					// update `enhanced:img` to `img`
 					s.update(node.start + 1, node.start + 1 + 'enhanced:img'.length, 'img');
-					imports.set(original_url, details.name);
+					imports.set(original_url, name);
 				}
 			}