Skip to content

Commit

Permalink
fix: ci - ensure unique test artifacts and correct matrix definition (#…
Browse files Browse the repository at this point in the history
…8615)

* fix: ensure uploaded artifacts have a unique name across test matrixes

* fix: use single entries for os value in test matrix includes
  • Loading branch information
dominikg authored Jan 19, 2023
1 parent 5805356 commit a7136c3
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ jobs:
matrix:
include:
- node-version: 16
os: [ubuntu-latest, windows-latest]
os: ubuntu-latest
e2e-browser: 'chromium'
- node-version: 16
os: windows-latest
e2e-browser: 'chromium'
- node-version: 18
os: ubuntu-latest
Expand Down Expand Up @@ -100,11 +103,11 @@ jobs:
- name: Archive test results
if: failure()
shell: bash
run: find packages -type d -name test-results -not -empty | tar -czf test-results.tar.gz --files-from=-
run: find packages -type d -name test-results -not -empty | tar -czf test-results-cross-browser.tar.gz --files-from=-
- name: Upload test results
if: failure()
uses: actions/upload-artifact@v3
with:
retention-days: 3
name: test-failure-${{ github.run_id }}-${{ matrix.os }}-${{ matrix.node-version }}-${{ matrix.e2e-browser }}
path: test-results.tar.gz
name: test-failure-cross-browser-${{ github.run_id }}-${{ matrix.os }}-${{ matrix.node-version }}-${{ matrix.e2e-browser }}
path: test-results-cross-browser.tar.gz

0 comments on commit a7136c3

Please sign in to comment.