Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOCKET_PATH feature of Node adapter is not documented #10256

Closed
Conduitry opened this issue Jun 26, 2023 · 0 comments · Fixed by #10484
Closed

SOCKET_PATH feature of Node adapter is not documented #10256

Conduitry opened this issue Jun 26, 2023 · 0 comments · Fixed by #10484
Labels
documentation Improvements or additions to documentation low hanging fruit

Comments

@Conduitry
Copy link
Member

Describe the bug

While reviewing #10041, I noticed that the SOCKET_PATH feature (which lets you listen on a specific domain socket, and was added in #2048) was not documented. It looks like that initial PR never added anything to the adapter-node readme about it, and so it never made its way into https://kit.svelte.dev/docs/adapter-node when we migrated the adapter docs to be part of the site.

Reproduction

n/a

Logs

No response

System Info

n/a

Severity

annoyance

Additional Information

No response

@Conduitry Conduitry added the documentation Improvements or additions to documentation label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation low hanging fruit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants