Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing paths.relative: undefined #11073

Closed
benmccann opened this issue Nov 18, 2023 · 2 comments
Closed

Consider removing paths.relative: undefined #11073

benmccann opened this issue Nov 18, 2023 · 2 comments
Milestone
2.0

Comments

@benmccann
Copy link
Member

Describe the problem

#11059 (comment)

Describe the proposed solution

Talk to Rich and figure out if we really need this or what exactly it does

Alternatives considered

No response

Importance

nice to have

Additional Information

No response
@benmccann benmccann added this to the 2.0 milestone Nov 18, 2023
@Rich-Harris
Copy link
Member

The context here is that we wanted paths.relative to be a boolean (that starting in 2.0 would default to true) but it would have been a breaking change: #9220 (comment)

We should indeed remove it in 2.0

@benmccann
Copy link
Member Author

A note as to relative paths on the web archive

Screenshot from 2023-11-20 13-23-48

@benmccann benmccann mentioned this issue Dec 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@benmccann @Rich-Harris