Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[create-svelte] Non TS demo app has type errors for the enhance action #4427

Closed
gtm-nayan opened this issue Mar 23, 2022 · 1 comment
Closed

[create-svelte] Non TS demo app has type errors for the enhance action #4427

gtm-nayan opened this issue Mar 23, 2022 · 1 comment

Comments

@gtm-nayan
Copy link
Contributor

Describe the bug

Without Typescript declarations marking them as optional, the type of the parameters to the action is inferred as { pending: any; error: any; result: any; } with all three fields required causing errors everywhere enhance is used in todos/index.svelte.

Reproduction

Default create-svelte template without Typescript

Logs

No response

System Info

.

Severity

annoyance

Additional Information

https://discord.com/channels/457912077277855764/956030069229359154
@gtm-nayan gtm-nayan mentioned this issue Mar 23, 2022
Closed
@Theo-Steiner Theo-Steiner mentioned this issue Apr 2, 2022
Closed
5 tasks
@Rich-Harris
Copy link
Member

closing in favour of #4428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Disable type checking for non-typescript projects by default Theo-Steiner/kit
2 participants
@Rich-Harris @gtm-nayan