Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite is fixed to version 3.0.2 in sveltejs/kit 1.0.0-next.418 ? #6004

Closed
kuchaguangjie opened this issue Aug 17, 2022 · 1 comment · Fixed by #5861
Closed

vite is fixed to version 3.0.2 in sveltejs/kit 1.0.0-next.418 ? #6004

kuchaguangjie opened this issue Aug 17, 2022 · 1 comment · Fixed by #5861
Labels
bug Something isn't working p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc.

Comments

@kuchaguangjie
Copy link

Describe the bug

I get following error in github action:

 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

.
└─┬ @sveltejs/kit 1.0.0-next.418
  └── ✕ unmet peer vite@3.0.2: found 3.0.8

hint: If you don't want pnpm to fail on peer dependency issues, add "strict-peer-dependencies=false" to an .npmrc file at the root of your project.

In my package.json, it's "vite": "^3.0.7".
Is there a reason to make vite fix to 3.0.2 ?

Reproduction

In package.json, set "vite": "^3.0.7", then start, and will get the above error.

Logs

No response

System Info

System:
    OS: Linux 5.14 Linux Mint 20.1 (Ulyssa)
    CPU: (8) x64 Intel(R) Core(TM) i7-4720HQ CPU @ 2.60GHz
    Memory: 8.22 GB / 15.55 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.1/bin/yarn
    npm: 8.17.0 - ~/.nvm/versions/node/v16.13.1/bin/npm
  Browsers:
    Chrome: 104.0.5112.79
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.64 
    @sveltejs/kit: next => 1.0.0-next.408 
    svelte: ^3.49.0 => 3.49.0 
    vite: ^3.0.7 => 3.0.7 



### Severity

serious, but I can work around it

### Additional Information

_No response_
@Conduitry Conduitry added bug Something isn't working p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc. labels Aug 17, 2022
@Conduitry
Copy link
Member

It looks like this happened as part of #5730, which I assume was not intended.

There are currently reasons for SvelteKit's copy of Vite for its own test suite to be pinned, but that shouldn't have been reflected in its peerDependency on Vite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants