Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapter-vercel should not use x-forwarded-proto #800

Closed
benmccann opened this issue Mar 31, 2021 · 2 comments
Closed

adapter-vercel should not use x-forwarded-proto #800

benmccann opened this issue Mar 31, 2021 · 2 comments
Labels
pkg:adapter-vercel Pertaining to the Vercel adapter

Comments

@benmccann
Copy link
Member

adapter-vercel is only using x-forwarded-proto so it can construct a valid URL in order to get pathname and searchParams. which seems wholly unnecessary
@benmccann benmccann added the pkg:adapter-vercel Pertaining to the Vercel adapter label Mar 31, 2021
@wiesson
Copy link
Contributor

wiesson commented Mar 31, 2021

I think that is going to be fixed in #801

@Conduitry
Copy link
Member

Oh, I didn't realize there was an issue for this. Yeah this is also fixed in #802 along with #801.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg:adapter-vercel Pertaining to the Vercel adapter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benmccann @wiesson @Conduitry