fix: updated @default annotation for runtime

[GauBen]

The default is not node18 as advertised but guessed at build time with the get_default_runtime function

---

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

• Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

[changeset-bot]

🦋 Changeset detected

Latest commit: c797e19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/adapter-vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[GauBen]

node${number}.x does not show auto-complete, which is not so great. I suggest explicit strings instead

[GauBen]

Better!

[eltigerchino]

The Vercel documentation mentions v20 as the default.

guessed at build time with the get_default_runtime function

Can you explain further what this means and how you came to this conclusion?

[GauBen]

The runtime is picked here

kit/packages/adapter-vercel/index.js

Line 219 in b74d796

const runtime = route.config?.runtime ?? defaults?.runtime ?? get_default_runtime();

It may default to node 20 if unspecified, but svelte-kit will always write a value to .vc-config.json

kit/packages/adapter-vercel/index.js

Line 638 in b74d796

runtime: config.runtime,

[eltigerchino]

Thanks! It's interesting because this means the node version can differ if building on Vercel versus building on the dev's machine then deploying using the CLI. Meanwhile, Vercel seems to use the same version for build and deployment if you link it to your repository.

Do you think it's enough that we clarify the default Vercel version is 20 but also add a note about the difference if it's built on a local machine and deployed?

[GauBen]

Do you think it's enough that we clarify the default Vercel version is 20 but also add a note about the difference if it's built on a local machine and deployed?

I guess that would work:

@default Same as the build environment.

- When building your project on Vercel, if this parameter is unset, it will [default to Node 20.x](https://vercel.com/docs/functions/runtimes/node-js/node-js-versions#default-and-available-versions).
- Otherwise, if you intend to build your application yourself with a Node version that is not [supported by Vercel](https://vercel.com/docs/functions/runtimes/node-js/node-js-versions#default-and-available-versions), you must set this parameter.

[eltigerchino]

cc: @dummdidumm any thoughts on this or preferences from Vercel?

[dummdidumm]

I'd like to keep this as the type because Vercel may deprecate old versions after some time and/or introduce new ones, and we don't want people to upgrade to newer versions of the adapter just for silencing type errors / don't want to make a major version bump just because we gotta remove a type

Suggested change

	runtime?: 'nodejs18.x' | 'nodejs20.x';
	runtime?: `nodejs${number}.x`;