From 5dadd8d799248b3d22e7dc852236a8f633316e73 Mon Sep 17 00:00:00 2001 From: Erica Pisani Date: Tue, 7 Jun 2022 15:42:02 -0400 Subject: [PATCH 1/4] fix: add redirect for routes containing __data.json suffix --- packages/adapter-netlify/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/adapter-netlify/index.js b/packages/adapter-netlify/index.js index 5d372ffe7eb4..1e0d6e704953 100644 --- a/packages/adapter-netlify/index.js +++ b/packages/adapter-netlify/index.js @@ -211,6 +211,7 @@ function generate_lambda_functions({ builder, publish, split, esm }) { writeFileSync(`.netlify/functions-internal/${name}.js`, fn); redirects.push(`${pattern} /.netlify/functions/${name} 200`); + redirects.push(`${pattern}/__data.json /.netlify/functions/${name} 200`); } }; }); From fb8906f4dd39a052ecb5c42e586096545223e1b6 Mon Sep 17 00:00:00 2001 From: Erica Pisani Date: Tue, 7 Jun 2022 16:41:14 -0400 Subject: [PATCH 2/4] fix: await for builder.createEntries to complete before writing redirects file --- packages/adapter-netlify/index.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/adapter-netlify/index.js b/packages/adapter-netlify/index.js index 1e0d6e704953..2a6a297f7ec8 100644 --- a/packages/adapter-netlify/index.js +++ b/packages/adapter-netlify/index.js @@ -150,7 +150,7 @@ async function generate_edge_functions({ builder }) { * @param { boolean } params.split * @param { boolean } params.esm */ -function generate_lambda_functions({ builder, publish, split, esm }) { +async function generate_lambda_functions({ builder, publish, split, esm }) { builder.mkdirp('.netlify/functions-internal'); /** @type {string[]} */ @@ -177,7 +177,7 @@ function generate_lambda_functions({ builder, publish, split, esm }) { if (split) { builder.log.minor('Generating serverless functions...'); - builder.createEntries((route) => { + await builder.createEntries((route) => { const parts = []; // Netlify's syntax uses '*' and ':param' as "splats" and "placeholders" // https://docs.netlify.com/routing/redirects/redirect-options/#splats From ee3ac20c9be204b9e31b2fafc412ac22fb1ab171 Mon Sep 17 00:00:00 2001 From: Erica Pisani Date: Tue, 7 Jun 2022 17:04:09 -0400 Subject: [PATCH 3/4] chore: add changeset entry --- .changeset/tasty-zebras-guess.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tasty-zebras-guess.md diff --git a/.changeset/tasty-zebras-guess.md b/.changeset/tasty-zebras-guess.md new file mode 100644 index 000000000000..c70973939c6b --- /dev/null +++ b/.changeset/tasty-zebras-guess.md @@ -0,0 +1,5 @@ +--- +'@sveltejs/adapter-netlify': patch +--- + +fix: add redirects for routes containing '\_\_data.json' suffix From 74d63c319c895b35f0b8207bb2f677c2fb9f636f Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Wed, 22 Jun 2022 10:26:36 -0400 Subject: [PATCH 4/4] Update tasty-zebras-guess.md --- .changeset/tasty-zebras-guess.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/tasty-zebras-guess.md b/.changeset/tasty-zebras-guess.md index c70973939c6b..31ba9456a796 100644 --- a/.changeset/tasty-zebras-guess.md +++ b/.changeset/tasty-zebras-guess.md @@ -2,4 +2,4 @@ '@sveltejs/adapter-netlify': patch --- -fix: add redirects for routes containing '\_\_data.json' suffix +fix: add redirects for routes containing `__data.json` suffix