Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] support linked @sveltejs/kit package in Vite 3.0.3+ #5861

Merged
merged 16 commits into from
Aug 17, 2022
Merged

[fix] support linked @sveltejs/kit package in Vite 3.0.3+ #5861

merged 16 commits into from
Aug 17, 2022

Conversation

benmccann
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 4b04480

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris changed the title [chore] update test apps to Vite 3.0.5 [chore] update test apps to Vite 3.0.7 Aug 15, 2022
@benmccann benmccann mentioned this pull request Aug 16, 2022
Merged
Conduitry
Conduitry requested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@Conduitry Conduitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vite 3.0.8 has been released now.

@Rich-Harris
Copy link
Member

The reason the tests are failing is that index.js and private.js are now being imported twice, breaking the instanceof check. I'm not sure what changed in Vite to break this

@Rich-Harris
Copy link
Member

It works with 3.0.2 and below, fails with 3.0.3 and above. Of the changelog entries, the following commits look most suspicious:

@Rich-Harris
Copy link
Member

It appears to only be a problem when the @sveltejs/kit package is linked — i.e. it's affecting our tests, and any projects that have something like this...

{
  "pnpm": {
    "overrides": {
      "@sveltejs/kit": "../kit/packages/kit",

...but not normal apps

@benmccann benmccann changed the title [chore] update test apps to Vite 3.0.7 [chore] update test apps to Vite 3.0.8 Aug 16, 2022
@Rich-Harris Rich-Harris linked an issue Aug 17, 2022 that may be closed by this pull request
vite is fixed to version 3.0.2 in sveltejs/kit 1.0.0-next.418 ? #6004
Closed
@Conduitry Conduitry changed the title [chore] update to Vite 3.0.8 and esbuild 0.14.54 [fix] support linked @sveltejs/kit package in Vite 3.0.3+ Aug 17, 2022
@Rich-Harris Rich-Harris merged commit 55d0531 into sveltejs:master Aug 17, 2022
@github-actions github-actions bot mentioned this pull request Aug 17, 2022
Merged
@benmccann benmccann deleted the vite-3.0.5 branch February 22, 2023 21:01
@benmccann benmccann mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry approved these changes

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vite is fixed to version 3.0.2 in sveltejs/kit 1.0.0-next.418 ?
3 participants
@benmccann @Rich-Harris @Conduitry