chore: separate out cross-browser tests #8585
Conversation
|
|
I think we can go further — there's no need to run unit tests (in |
|
gah looks like the symlinks need to be fixed. will do in the morning if no-one beats me to it |
| @@ -9,7 +9,10 @@ | |||
| "check": "svelte-kit sync && tsc && svelte-check", | |||
| "test": "node test/setup.js && pnpm test:dev && pnpm test:build", | |||
| "test:dev": "rimraf test/errors.json && cross-env DEV=true playwright test", | |||
| "test:build": "rimraf test/errors.json && playwright test" | |||
| "test:build": "rimraf test/errors.json && playwright test", | |||
There was a problem hiding this comment.
I notice that writes/package.json also does rimraf test/errors.json despite it only being created in the basics test, so perhaps we could clean remove it from that file
There was a problem hiding this comment.
done. would love to find a way to not need that errors.json thing, it's super awkward
There was a problem hiding this comment.
i wonder if we could put the error on event.locals then return it with the response via a x-error header or something. might try that after we merge this change
I thought I'd share this for discussion as it may be a bit easier to evaluate the idea while being able to look at a potential breakdown of which tests would be run cross-browser. I've got roughly half the tests running cross-browser (i.e. on WebKit). We could probably fine tune a bit which ones live where and I'm totally open to moving tests from one file to another.
This should also cut down our quota usage significantly since macOS is charged at a 10x rate
Closes #8578