Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) replace flatMap (node 11+) with flatten util #135

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

dummdidumm
Copy link
Member

No description provided.

@dummdidumm
Copy link
Member Author

.. or we just keep it as is but require at least node 11. @ehrencrona thoughts?

@Conduitry
Copy link
Member

I would vote for this PR rather than doing a major version bump and requiring Node 11. (I'm not sure whether there's already been a release that contains this code, but if so, it would be irresponsible not to release another patch fix even if we decided to go forward with a major version that notes the newer Node requirement.) I'd also vote for running CI on the oldest version of Node we say we support, to catch issues like this earlier.

@benmccann
Copy link
Member

I think it's reasonable to support Node 10, which is still supported until 2021-04-30.

@dummdidumm
Copy link
Member Author

dummdidumm commented Sep 3, 2020

flatMap apparently came in through #78, so since March. I agree with you, I'll merge this in.

@dummdidumm dummdidumm merged commit 9382490 into sveltejs:master Sep 3, 2020
@dummdidumm dummdidumm deleted the flatmap branch September 3, 2020 15:53
@ehrencrona
Copy link
Contributor

Since it’s also only about a single function that’s easy to replace I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants