Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Documentation bookmarks not working #1290

Closed
benmccann opened this issue Jun 24, 2020 · 5 comments · Fixed by #1292
Closed

Documentation bookmarks not working #1290

benmccann opened this issue Jun 24, 2020 · 5 comments · Fixed by #1292

Comments

@benmccann
Copy link
Member

Describe the bug
When I go to https://sapper.svelte.dev/docs#this_error it usually leaves me at the top of the page instead of scrolling down to the appropriate section of the page. This does not seem to always happen, so perhaps its a race condition

To Reproduce
It doesn't work more than it does for me, but you may need to refresh a few times to see it

Expected behavior
I'm taken to the appropriate section of the docs

Information about your Sapper Installation:

  • Your browser and the version: Chrome 83
  • Your operating system: Ubuntu

Severity
Just a little annoying if it's only a bug with the documentation website. More serious if it's a bug that affects all Sapper applications

@antony
Copy link
Member

antony commented Jun 24, 2020

@benmccann I have a feeling that this is a Sapper bug which I can't locate right now.

@Conduitry
Copy link
Member

Hopefully this would be fixed by #1139 but I haven't tried. The version of Sapper that the Sapper site is built with is a bit old.

@benmccann
Copy link
Member Author

Ah, thanks! You probably just saved me a bunch of time trying to track this down

@Conduitry
Copy link
Member

👍 Thanks! I've merged #1292 and redeployed the site.

@benmccann
Copy link
Member Author

thanks!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants