Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Rename rel=prefetch to sapper:prefetch #1401

Closed
benmccann opened this issue Aug 13, 2020 · 3 comments · Fixed by #1566
Closed

Rename rel=prefetch to sapper:prefetch #1401

benmccann opened this issue Aug 13, 2020 · 3 comments · Fixed by #1566
Labels
breaking Breaking Changes

Comments

@benmccann
Copy link
Member

Sapper overrides the browser's default rel=prefetch behavior. There seemed to be agreement that we should stop doing this.

@benmccann benmccann added the breaking Breaking Changes label Aug 13, 2020
@arekbartnik
Copy link
Contributor

I think it would also be good to change the rel=external. It feels weird to use existing attributes for different behaviors.

@Conduitry
Copy link
Member

rel="external" is a real thing though, which already means precisely what Sapper is using as. https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel The problem with rel="prefetch" is that it looks like a real thing but it is not.

@arekbartnik
Copy link
Contributor

@Conduitry what would you do if you had an sapper app on a [domain] with links to [domain]/[category] but [category] wasn’t part of your sapper app? Logically, all referenced resources are part of the site but not part of the sapper app. Using rel=external for these links is a “feel weird” part for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking Changes
Projects
None yet
3 participants