Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Deeplinks not functioning as expected #479

Open
mattpilott opened this issue Oct 17, 2018 · 3 comments
Open

Deeplinks not functioning as expected #479

mattpilott opened this issue Oct 17, 2018 · 3 comments
Labels

Comments

@mattpilott
Copy link

After updating to 0.23.3 and looking at the changes I tested an anchor link only to find that instead of scrolling or snapping to the anchor on page it went to the root domain with the anchor see screen.

Perhaps related to #472 and/or #341

screenshot 2018-10-17 at 10 11 58 am

@Conduitry
Copy link
Member

What version were you running before when that link was working? For quite some time, you have had to specify an entire path in links, even ones intended to by anchor links to the same page. See, e.g., this PR, which fixes a link on the Svelte docs site, at which time that site was using Sapper 0.12.

@mattpilott
Copy link
Author

I've updated from 0.23 however i havent ever tested this before, the only issue is I have no control over the links in the content as they are pulled from a cms. Should sapper not attempt to replicate default browser behaviour here?

@maxmilton
Copy link

It's always been a bug. I tend to use a lot of "deeplinks" so I know it's a bit frustrating as currently you need to add the full path in the href.

This is because of the <base> tag in the head. See issue #228.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants