sass: remove sourceMappingURL from result.code #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
approved these changes
Jan 14, 2021
Closed
kaisermann
approved these changes
Jan 29, 2021
|
Ni-ni-ni-nice! Thanks! Released in v4.6.5 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issue #286 and PR sveltejs/svelte#5854
sourcemaps should be returned either in result.map or in result.code but not in both
keeping the
/*# sourceMappingURL=component.svelte.map */magic commentmakes the browser display wrong mappings*can* make the browser display wrong mappings, if the sourcemap file exists (
component.svelte.map)(there is another bug with sourcemaps, so mappings are still wrong in the browser)fixed by sveltejs/rollup-plugin-svelte#175