Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte migration omits a property and produces unnecessary children snippet #14258

Closed
machycek opened this issue Nov 11, 2024 · 0 comments · Fixed by #14260
Closed

Svelte migration omits a property and produces unnecessary children snippet #14258

machycek opened this issue Nov 11, 2024 · 0 comments · Fixed by #14260

Comments

@machycek
Copy link

Describe the bug

I have a components that consumes Link and Text component. When I migrate the Svelte 5 it removes variant prop and adds a children snippet.

I imagine that it might be related to #14224

Reproduction

Before
https://svelte.dev/playground/hello-world?version=5.1.13#H4sIAAAAAAAAE22PsU7DQAyGX-VkVSpIbSIxoZBEYmNgYGDjGK6JW0692Kez2waivDs6WqQOHf3p_37bE5AbECp4wRDYnDiF3txh7xX7e1jB1gcUqD4m0O-YcxnA6t96jrGQIwbNbOMEb_GOSZFUoIJauuSjmuBo11hQsdBaMsYPkZOadxzVbBMPZrnoeIhM2SszLj31OF5Kl09X0mRePe3NfEM8-DJ42ud4XZ5Xt5Ys1dnIFUeXvCNtLPBBgyfsLWQu_gcbCzKcxy44kcbC4Mb1af3waE7od1-63nC4CMrNtFgkFH1LHKVQnjOeiqK4wrOlv3drCaymbPNZ-ZTWEqxAcVSoNB1w_px_AV3wLtuZAQAA

After

https://svelte.dev/playground/hello-world?version=5.1.13#H4sIAAAAAAAAE21RTWsbMRD9K4Ma8BrsXeiprL1Oe-uhh0J7y4airMaOsHYkpIk_KvTfy2TXIZQchKSn9968GWVFekTVqu_onIezj85AhcYymqVaqb11mFT7kBVfg_AEUKub6lsIdTqhY8GedMKP8METI3FSrdqmIdrA4DQdul5x6tWuJwA7Bh8ZfuOFYR_9CIu7wY_Bk-gagRtLBi-z6WLzTpThh6UjlA-EL7Zxlo4znRjjXg8IP6MPCbKAAMOzdSYi3bezYbWYiyzrX2RDQN5MzIcjXltIHC0dHlvQdBW89CSbQ0lyM1tBXdcRE0Np53Id3AU5VMvNpBg8JX5T_IlIBqPQDEZ7QlPdnkSwbabJ7US7lYbFQlayf7HrVRp79erqdEpdr0Z9WZ_Xn7_AGe3hmddP3pmJwb7LEq1mX-Se56ilp9e_yJ_S1PZbtirDSUeriaEsyzSM_HUO_F8D93U1UXIz2xRJL4l3PamVYrywajm-YHks_wDYMeO7fwIAAA==

Logs

No response

System Info

System:
    OS: macOS 14.6.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 4.10 GB / 64.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
    Yarn: 1.22.21 - /usr/local/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
    pnpm: 9.12.3 - ~/.nvm/versions/node/v20.11.0/bin/pnpm
    Watchman: 2024.03.25.00 - /usr/local/bin/watchman
  Browsers:
    Brave Browser: 107.1.45.133
    Chrome: 130.0.6723.117
    Safari: 17.6
  npmPackages:
    svelte: ^5.0.0 => 5.1.13

Severity

blocking an upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant