-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot set properties of null (setting 'currentTime'), when transition #15053
Comments
This is a continuation of #15008 @paoloricciuti perhaps you might want to take a look, since you fixed the first one |
Yeah I took a quick look, I think I know what's happening but I need to figure that out at the desk |
Uhm actually...i don't think there's much we can do here. What is happening is that by using a transition you are delaying the unmount of the element from the DOM. So the audio keep playing and the time keeps changing. But since you are binding to a variable that is now But when you have a transition the element needs to stay, and as long as an element is in the dom the bind needs to still be applied (especially because you could write to an external variable which is not affected by the if). Imagine for example a situation like this...would you expect the time to not update while the transition is playing? |
Maybe I am missing something, but the audio shouldn't be playing because we paused it before unmount since we pressed stop |
You never actually paused the audio...you rely on the removal of the element from the Dom for it to stop but if you are using a transition that happens after the transition |
They tried to pause through the In this version, try jumping after pausing, while the outro is still playing. It works if you pause through the audio native controls, but not through the |
Describe the bug
When playing audio HTML element with binded currentTime value becomes hidden with transition, the Svelte still tries to set the value of the now missing property (while animated), which results in an error Cannot set properties of null.
Reproduction
Full example: REPL
Press play and then hide the player
Logs
System Info
Severity
annoyance
The text was updated successfully, but these errors were encountered: