Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outro's are always local #2334

Closed
halfnelson opened this issue Mar 29, 2019 · 3 comments
Closed

Outro's are always local #2334

halfnelson opened this issue Mar 29, 2019 · 3 comments
Labels

Comments

@halfnelson
Copy link
Contributor

halfnelson commented Mar 29, 2019

I think it is because of this line here.

let outro_block = deindent`
${outro_name} = @create_out_transition(${this.var}, ${fn}, ${snippet});
`;
if (outro_block) {
outro_block = deindent`
if (#local) {
${outro_block}
}
`;
}

My reading is the if statement will always be true, so might be a typo (maybe it should be outro.is_local

@Conduitry Conduitry added the bug label Apr 15, 2019
@Conduitry Conduitry added this to the 3.0 milestone Apr 15, 2019
@Rich-Harris
Copy link
Member

Can you repro? It's working correctly here — https://v3.svelte.technology/tutorial/local-transitions — in the chapter's initial ('broken') state, toggling the checkbox causes non-local transitions to play on both intro and outro.

@halfnelson
Copy link
Contributor Author

Sure. Transistions are fine, It was a while ago but I think it only applies to outros. I take the tutorial and change from transition to out and I get the different behaviour.
https://v3.svelte.technology/repl?version=3.0.0-beta.28&gist=d84c927e6831740749d7b56bb298365a

@Rich-Harris Rich-Harris modified the milestones: 3.0, 3.x Apr 21, 2019
@halfnelson
Copy link
Contributor Author

Looks like there is a PR for a duplicate issue here #2690
#2689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants