Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide AST node types with internal types stripped out #12967

Closed
wants to merge 3 commits into from

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Aug 22, 2024

Uses new dts-buddy capabilities and the corresponding tsconfig option to strip away types/properties (and their dependencies) that are marked with @internal

Also hides the legacy AST types from the output

closes #12292

There's the "Component" interface which overlaps with the interface of the same name from svelte - do we want to rename this? Prefix all with Ast?

Draft because it depends on Rich-Harris/dts-buddy#87 being merged and released

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

…to strip away types/properties (and their dependencies) that are marked with `@internal`
Also hides the legacy AST types from the output

closes #12292
Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 2e86890

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member Author

Closing in favor of #12968

@dummdidumm dummdidumm closed this Sep 1, 2024
@dummdidumm dummdidumm deleted the ast-types branch September 1, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Svelte AST node types from svelte/compiler to public
1 participant