Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide AST node types with internal types stripped out (alternative) #12968

Merged
merged 10 commits into from
Sep 1, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Aug 22, 2024

Alternative to #12967 which moves all nodes into an AST namespace. Sadly, I found out after adjusting the whole codebase that it doesn't work properly because dts-buddy can't handle this properly. Not sure if we should look into it or just go with
#12967 instead
(fixed in dts-buddy).

Question remaining is, whether or not we should also expose the type unions, like SvelteNode etc, or just the AST nodes themselves. I lean towards the latter, which would mean I need to tweak this PR a bit. Update: we decided to hide those

Depends on Rich-Harris/dts-buddy#87 and Rich-Harris/dts-buddy#89 being merged and released

closes #12292

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

…to strip away types/properties (and their dependencies) that are marked with `@internal`
Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: e17a930

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm marked this pull request as draft August 22, 2024 11:10
@dummdidumm
Copy link
Member Author

Will self-merge once green to not introduce more merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Svelte AST node types from svelte/compiler to public
1 participant