Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore @sveltejs/package and svelte2tsx for generated vite config #711

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Aug 9, 2023

fixes #710

our vitefu setup detected @sveltejs/package as a library that uses svelte because of it's peer dep on svelte. But in this case it isn't used when building the actual application, so we have to ignore it here.

packages/e2e-tests/kit-node/__tests__/kit.spec.ts Outdated Show resolved Hide resolved
packages/e2e-tests/kit-node/__tests__/kit.spec.ts Outdated Show resolved Hide resolved
@dominikg dominikg merged commit 74cf82f into main Aug 10, 2023
7 checks passed
@dominikg dominikg deleted the fix/never-optimize-svelte-package branch August 10, 2023 07:58
@github-actions github-actions bot mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sveltejs/package missing import in package.json.exports['.']?
2 participants