Optional http #44
Merged
Optional http #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Furthermore, I considered updating your CI, but none of LTS Ubuntu releases contains glslang of the required version. Latest Ubuntu and possibly some released Fedora container do, let me know if you are interested in adding a CI for testing distro builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to #43, this change conditionalizes the use of mongoose library. I was trying really hard to find a Linux distro that provides mongoose 6.9 but none of Fedora, Debian or Arch provide it.
Therefore I assume it is good to make it simple to disable HTTP support.