fixed-client-target: changed client target setting, following glslangValidator approach #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Validator approach
mixnam
force-pushed
the
fixed-client-target
branch
from
99d0ca4 to
ed9b5f3
Compare
|
@nolanderc wanna take a look? |
|
Looks good! Thank you! |
|
Hey there, any chance we could get a new release tag cut with this change included? Just confirmed by manually building master branch that this change makes glslls viable for a webgl2 project; without this, its diagnostics are misaligned with what webgl2 wants. |
|
Ok here you go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to solve these issues
As I found, currently we are setting envClient and envTarget every time, no matter what kind of client we user specified via cli args.
However it might be a wrong approach. In glsllang repo I noticed that for OpenGL we should not set these properties at all .
I was trying to implement same logic here, and bound
EShMessages messageswith target client version specified via cli args.NOTE:
I don't have any experience in c++ and contribution to open source, please don't blame me too much. And I would more than appreciate any help from anybody.