feat: add better YAML syntax error messages #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
commented
Jul 12, 2023
There was a problem hiding this comment.
@damian-polewski-sb please have a look at my suggestions to tests and if you agree please amend the rest of the tests with the suggestions.
packages/apidom-parser-adapter-yaml-1-2/test/adapter-browser.ts
Outdated
Show resolved
Hide resolved
packages/apidom-parser-adapter-yaml-1-2/test/adapter-browser.ts
Outdated
Show resolved
Hide resolved
packages/apidom-parser-adapter-yaml-1-2/test/adapter-browser.ts
Outdated
Show resolved
Hide resolved
packages/apidom-parser-adapter-yaml-1-2/test/adapter-browser.ts
Outdated
Show resolved
Hide resolved
17 tasks
char0n
commented
Jul 12, 2023
packages/apidom-parser-adapter-yaml-1-2/test/adapter-browser.ts
Outdated
Show resolved
Hide resolved
|
@char0n Thanks for the suggestions! I added them in the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2914
Refs #2889
Assigning a constant error message is happening as late as possible - during the YAML AST -> ApiDOM syntactic analysis.
The error message format is consistent with the established error message formats:
(Error <value>)(Unexpected <value>)Tests in
apidom-lshave been adapted.